acme: fix double-free in acmeerrorproc

The receiver of cerr takes ownership of s.
madlambda · Mar 23, 2021 · 7366140 · 7366140
1 parent 9097137
commit 7366140
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/cmd/acme/acme.c b/src/cmd/acme/acme.c
@@ -383,17 +383,15 @@ int erroutfd;
 void
 acmeerrorproc(void *v)
 {
-	char *buf, *s;
+	char *buf;
 	int n;
 
 	USED(v);
 	threadsetname("acmeerrorproc");
 	buf = emalloc(8192+1);
 	while((n=read(errorfd, buf, 8192)) >= 0){
 		buf[n] = '\0';
-		s = estrdup(buf);
-		sendp(cerr, s);
-		free(s);
+		sendp(cerr, estrdup(buf));
 	}
 	free(buf);
 }