fix(rdkafka): fix unintended drop of client in fetch_watermarks
#200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
BugenZhao
reviewed
Mar 24, 2024
| let topic_c = CString::new(topic.to_string())?; | ||
| let native_client = unsafe { NativeClient::from_ptr(self.native_ptr()) }; | ||
| let native_ptr = NativePtr(self.native_ptr()); |
There was a problem hiding this comment.
It does not seems to be safe if we cancel the future for spawn_blocking. 😕 We may require an Arc<Self> here considering that StreamConsumer holds an Arc over BaseConsumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Runji Wang wangrunji0408@163.com
release madsim-rdkafka v0.3.4 and yank v0.3.3