-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move crates into a cargo workspace #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhantomFn has been deprecated and is now causing an ICE on the latest nightly, but in order to continue compiling on the beta we still need some bound on the traits, so use Sized. Fixes #21.
They can be removed since beta 2 was published. Fixes #22.
Previously, if the given closure panicked it could cause the stack to unwind in an inconsistent state, where the result or closure was just garbage data but would still be dropped.
StrEncoding doesn't really offer anything now, and I don't think it's very efficient. I'd rather make it private until sure I'm happy with it.
Turns out that the runtime encodes both signed and unsigned chars as strings regardless of the signedness of char. And turns out there's a c_void in libcore now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge the following crates into this (
objc
), to have a single shared repo:objc-encode
objc_exception
objc_id
objc-foundation
postponedblock
postponeduikit
postponeddispatch
Done with
git merge --allow-unrelated-histories
.See SSheldon/rust-objc#101 for more reasoning.