Verify that an Ids' ownership is correct using associated objects
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
associated-id-unique
branch
from
58ba8fa to
0233bfc
Compare
madsmtm
added
the
A-objc2
madsmtm
added a commit
that referenced
this pull request
Jun 12, 2022
Found while experimenting with verification using associated objects in #127.
madsmtm
added a commit
that referenced
this pull request
Jun 12, 2022
Found while experimenting with verification using associated objects in #127.
madsmtm
added a commit
that referenced
this pull request
Jun 12, 2022
Found while experimenting with verification using associated objects in #127.
madsmtm
force-pushed
the
associated-id-unique
branch
from
0233bfc to
5e8bcec
Compare
|
I think I may put this behind an unstable feature that you'd enable while testing, to move it forwards for now! |
|
Ownership is now tracked in a substantially different way, and usually things won't be mutable, so I don't think this has enough value to be worth the cost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves upstream SSheldon/rust-objc-id#5.
A downside to this is that
ManuallyDrop::new(id)no longer works properly, you'd have to useid.forget(), which is less ergonomic.I do think this is a good idea, it helped me catch a bug in
NSArray::new(NSArray::newalways returns the same object), fix included in #163.TODO: