Statically find msgSend functions on apple devices
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that we don't incur performance overhead for that (though we probably didn't before anyways).
This is also more correct since it allows the following:
#[repr(transparent)]
struct Wrapper {
inner: f32,
}
unsafe impl Encode for Wrapper {
const ENCODING: Encoding<'static> = f32::ENCODING;
}
madsmtm
force-pushed
the
static-msg-send
branch
from
6b1c9f6 to
5f3fa07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions are found by looking at the
Encode::ENCODINGand size of the return type.This ensures that we don't incur a performance overhead for that (though we probably didn't before anyways).
This is also more correct since it allows the following:
To use the correct
msgSendimplementation.