Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Id::downgrade #197

Closed
wants to merge 1 commit into from
Closed

Add Id::downgrade #197

wants to merge 1 commit into from

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Jul 16, 2022

Solves remaining part of #58. Unsure about the exact design!

TODO:

  • Limit when not 'static
  • Maybe add extra trait?
  • Make sure this follows SB (so if we use Deref, don't actually go through said deref, instead just use a cast directly)
  • Documentation
  • ...

@madsmtm madsmtm added enhancement New feature or request A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates labels Jul 16, 2022
@madsmtm madsmtm mentioned this pull request Jul 16, 2022
Merged
@madsmtm madsmtm mentioned this pull request Aug 1, 2022
Merged
@madsmtm
Copy link
Owner Author

madsmtm commented Aug 1, 2022

Superceded by #234

@madsmtm madsmtm closed this Aug 1, 2022
@madsmtm madsmtm deleted the id-downgrade branch August 1, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-objc2 Affects the `objc2`, `objc2-exception-helper` and/or `objc2-encode` crates enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@madsmtm