Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LongDouble, FloatComplex, DoubleComplex and LongDoubleComplex encodings #20

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

madsmtm
Copy link
Owner

@madsmtm madsmtm commented Sep 4, 2021

Found while working on objc_sys (#19), there might be others we're missing so I've marked Encoding with #[non_exhaustive].

Won't merge this before I've done a proper investigation!

@madsmtm madsmtm added the bug Something isn't working label Sep 4, 2021
@madsmtm

This comment has been minimized.

@madsmtm
Copy link
Owner Author

madsmtm commented Oct 29, 2021

We should also consider implementing RefEncode for integer types (and investigate the String encoding on i8/u8) Done in #52

@madsmtm
Copy link
Owner Author

madsmtm commented Oct 29, 2021

And maybe RefEncode (though not Encode, since Box is Drop) for Box? Moved to #52

@madsmtm
Copy link
Owner Author

madsmtm commented Oct 29, 2021

And forwarding impls for Wrapping<T>? Done in #52

@madsmtm
Copy link
Owner Author

madsmtm commented Oct 30, 2021

Does objc2_encode require knowledge of the compiler and runtime? E.g. it is often allowed to omit details like in, inout, oneway and so on, but does this change significantly across compilers and/or runtimes?

Found while working on objc_sys, there might be others we're missing so I've marked `Encoding` with `#[non_exhaustive]`
@madsmtm
Copy link
Owner Author

madsmtm commented Nov 3, 2021

An long double and the three _Complex floating point types are now supported, other encodings can be added on a case-by-case basis (since Encoding is #[non_exhaustive]). See also #68

@madsmtm madsmtm merged commit 076d711 into master Nov 3, 2021
@madsmtm madsmtm deleted the encode-complex branch November 3, 2021 12:00
@madsmtm madsmtm added this to the objc2 v0.3 milestone Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant