-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libstd from objc-sys and block-sys #305
Conversation
Yeah, this crate doesn't have a policy yet so this wouldn't be a breaking change; however, I would still like it to work with |
We could use |
I think I've also sort-of tried to keep the amount of dependencies down. For now, I've kinda deemed that the downsides of "bump Rust version" or "added dependency" outweigh the benefit " But in a few months, when 1.64 is in |
One thing to note is that the Tauri project seems to want to keep an MSRV of 1.61. I'm not sure if I would let that be a deciding factor, just something to be aware of considering #174. |
Whoops, I was deleting forks and I accidentally deleted the fork with this change. Now that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'd be fine with a MSRV bump, mostly because some things are much easier to express with GATs (from Rust 1.65).
Another thing that would be nice is more capabilities for const fn
, esp. the fn
pointer handling for eventually allowing safe method overriding in declare_class!
. I'd also really like to start using ptr::cast_mut
!
All in all we don't really gain that much from the bump yet though, since objc2
still needs std::sync::Once
for declare_class!
.
I think perhaps we could avoid that completely with a helper like objc2::__macro_helpers::CachedClass
+ (ab-)using the fact that the objc
runtime is locked while creating classes? Or maybe we'd need to re-implement parts of std::sync::Once
? Or perhaps do so using functionality from libdispatch
?
Do you know what the recommended approach is for std::sync::Once
-like functionality in no_std
?
#[cfg(feature = "std")] | ||
extern crate std; | ||
|
||
#[cfg(not(feature = "std"))] | ||
compile_error!("The `std` feature currently must be enabled."); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do roughly the same setup as I did in this PR to the url
project (for both alloc
and std
, since neither are required).
Not as enthusiastic about this anymore. |
No problem, I'll probably get around to doing it myself at some point, then I'll use the code here |
This removes
libstd
as a dependency forobjc-sys
andblock-sys
, by replacingstd::os::raw
withcore::ffi
, which contains the necessary types.This bumps to MSRV to at least 1.64, but it looks like this package doesn't have an MSRV policy yet (#203), so I hope that's not an issue.