Add sys crate for blocks #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
block-sys
branch
3 times, most recently
from
b9c86ad to
4559a4a
Compare
NSData initWithBytesNoCopy:length:deallocator: is broken in GNUStep, see gnustep/libs-base#213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces upstream SSheldon/rust-block#2, which makes GNUStep and WinObjC work with blocks. Kudos to @ngrewe for the original implementation (see also their explanation of the problem), I chose to not go the "autoconfigure" route since I wanted to pull in
objc2_sysas a dependency when GNUStep support was requested (and this requires using features).In the end, this makes blocks work on GNUStep!