Skip to content
This repository has been archived by the owner on Dec 21, 2024. It is now read-only.

Make argument optional #164

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Make argument optional #164

merged 1 commit into from
Feb 14, 2023

Conversation

afallou
Copy link
Contributor

@afallou afallou commented Feb 14, 2023

Fixes #163

Why?

In version 2.0.5 a new, non-optional argument to merge_record_extra was added, making the version non-backward-compatible.

What?

  • Make that new argument optional.
  • Add test case making sure the method can be called without the argument.

Why?
In version `2.0.5` a new, non-optional argument to `merge_record_extra` was added, making the version non-backward-compatible.

What?
- Make that new argument optional.
- Add test case making sure the method can be called without the argument.
Copy link
Owner

@madzak madzak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@madzak madzak merged commit 4e9b241 into madzak:master Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version 2.0.5 is backward-incompatible
2 participants