Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS Check First Push #440

Merged
merged 25 commits into from
Sep 11, 2024
Merged

CIS Check First Push #440

merged 25 commits into from
Sep 11, 2024

Conversation

NZLostboy
Copy link
Contributor

First cut for some of the CIS checks.

This is the CIS checks that can be automated (according to CIS, I realise some of them can be done other ways and I will get to that) down to check 1.3.6.

I realise as I am writing this that I have missed the docs/commands entries so I will go back and do those today and add them here.

In the mean time if I could get a review and feedback on whats currently pushed that would be great.

@NZLostboy NZLostboy requested review from a team as code owners August 30, 2024 21:12
Copy link
Contributor

@soulemike soulemike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments for feedback. Looks like a good start. Thanks!

@NZLostboy
Copy link
Contributor Author

Here are some comments for feedback. Looks like a good start. Thanks!

Thank you, I will spend some time in the next day or so sorting them all out and adding the other bits.

@soulemike
Copy link
Contributor

This is looking good @NZLostboy, I think the MD file and then passing build tests and this would be good for review. Thank you!

@NZLostboy
Copy link
Contributor Author

This is looking good @NZLostboy, I think the MD file and then passing build tests and this would be good for review. Thank you!

Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest.

I will add that note and try to work out the build fails today and then it can go through review.

@soulemike
Copy link
Contributor

Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest.

No need to manually build the mdx those get generated by the pipelines when the PR gets merged.

@NZLostboy
Copy link
Contributor Author

Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest.

No need to manually build the mdx those get generated by the pipelines when the PR gets merged.

Oh awesome! alright I will work on getting the builds fixed

@NZLostboy
Copy link
Contributor Author

Builds fixed, sorry for the number of builds. I didn't know how to perform the tests locally but now I do.

Copy link
Contributor

@merill merill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is looking good!

@merill merill merged commit a0e100a into maester365:main Sep 11, 2024
4 checks passed
@NZLostboy NZLostboy deleted the cis branch September 11, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants