-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIS Check First Push #440
CIS Check First Push #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some comments for feedback. Looks like a good start. Thanks!
Thank you, I will spend some time in the next day or so sorting them all out and adding the other bits. |
Updated the Microsoft 365 admin center URL in the remediation actions to be a MD url
Update check to limit results to 6 and only show failed results
This is looking good @NZLostboy, I think the MD file and then passing build tests and this would be good for review. Thank you! |
Thanks @Snozzberries , I have started building out the .mdx files for each test, I assume that is what I am supposed to do with the .mdx files? I am not that familiar with them to be honest. I will add that note and try to work out the build fails today and then it can go through review. |
No need to manually build the mdx those get generated by the pipelines when the PR gets merged. |
Oh awesome! alright I will work on getting the builds fixed |
Required to fix PSUseSingularNouns
Builds fixed, sorry for the number of builds. I didn't know how to perform the tests locally but now I do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This is looking good!
First cut for some of the CIS checks.
This is the CIS checks that can be automated (according to CIS, I realise some of them can be done other ways and I will get to that) down to check 1.3.6.
I realise as I am writing this that I have missed the docs/commands entries so I will go back and do those today and add them here.
In the mean time if I could get a review and feedback on whats currently pushed that would be great.