Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #109

Merged
merged 1 commit into from
Nov 30, 2018
Merged

Update README.md #109

merged 1 commit into from
Nov 30, 2018

Conversation

gaga-change
Copy link
Contributor

invalid syntax

This PR contains:

  • bugfix
  • feature
  • refactor
  • tests
  • documentation
  • metadata

Breaking Changes?

  • yes
  • no

If yes, please describe the breakage.

Please Describe Your Changes

Fix the syntax error in the sample code

@gaga-change
Update README.md
9483c69 
invalid syntax
@CanRau
Copy link

CanRau commented Nov 30, 2018

Great PR already in place 👏
After merging this PR a new release could be pushed to NPM as well as their readme still reads mapHeader (missing S) and the example of mapValues show the same wrong mapHeader, that would be nice
Just my 2cents 😉

@shellscape shellscape merged commit 515a190 into mafintosh:master Nov 30, 2018
shellscape pushed a commit that referenced this pull request Nov 30, 2018
@gaga-change @shellscape
docs: correct mapHeaders function name (#109)
329d3bf 
invalid syntax
shellscape pushed a commit that referenced this pull request Nov 30, 2018
@gaga-change @shellscape
docs: correct syntax error in example usage (#109)
c319472 
invalid syntax
This was referenced Sep 23, 2019
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaga-change @CanRau @shellscape