fix: update execa dependency to 2.1.0 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update execa dependency to 2.1.0 in package-lock.json. Without this change, tests will fail when run with Node.js 13.x-pre and may fail when 13.0.0 is released in 13 days.
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 97.24% 97.24%
=======================================
Files 1 1
Lines 145 145
=======================================
Hits 141 141
Misses 4 4Continue to review full report at Codecov.
|
|
Thanks for this PR 🍺 |
|
I know it's just a test fix, but any chance I can persuade you to publish a new release? There seem to be some legitimate bug fixes since the last release, so it wouldn't be a complete no-change release for end users. This particular fix will help Node.js's ecosystem-testing tool CITGM, which downloads a tarball of the latest release and runs tests. So CITGM won't use this fix until it's part of a release. |
This was referenced Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
If yes, please describe the breakage.
Please Describe Your Changes
Update execa dependency to 2.1.0 in package-lock.json. Without this
change, tests will fail when run with Node.js 13.x-pre and may fail when
13.0.0 is released in 13 days.
Refs: sindresorhus/execa#370