Set error name to SyntaxError #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkehres
commented
Jun 22, 2017
test/test.js
Outdated
| var bops = require('bops') | ||
| var spectrum = require('csv-spectrum') | ||
| var concat = require('concat-stream') | ||
| var csv = require('..') | ||
| var read = fs.createReadStream | ||
| var eol = '\n' |
There was a problem hiding this comment.
On Windows EOL is '\r\n', which causes a few tests to fail. Making this '\n' across all operating systems fixes this problem.
shellscape
requested changes
Aug 17, 2018
index.js
Outdated
| @@ -156,7 +156,9 @@ Parser.prototype._online = function (buf, start, end) { | |||
| } | |||
|
|
|||
| if (this.strict && cells.length !== this.headers.length) { | |||
| this.emit('error', new Error('Row length does not match headers')) | |||
| var e = new Error('Row length does not match headers') | |||
| e.name = 'SyntaxError' | |||
There was a problem hiding this comment.
I don't believe that SyntaxError is correct here. According to the Node docs: https://nodejs.org/api/errors.html#errors_class_syntaxerror, this is used only for invalid JavaScript , or as a result of code evaluation.
RangeError should be more appropriate https://nodejs.org/api/errors.html#errors_class_rangeerror. And it's a built-in, so no need to set the name property, just instantiate directly.
shellscape
approved these changes
Aug 18, 2018
|
Note: Given the age of the PR and no response from the author for 24 hours, I have updated this PR to use |
Closed
Merged
shellscape
added a commit
that referenced
this pull request
Sep 25, 2018
* chore: add metadata, update package, use eslint+standard * chore: update pre-commit hook * refactor: update linting for node 6+ * chore: make bench a script * refactor: make benchmarks a bin, add style * fix: index linting without breaking tests * fix: bench bin should accept file input * docs: spruce up the README * chore: reorg binaries * chore: add repo labels json * refactor: Use RangeError (#73) * Set error name to SyntaxError * chore: use RangeError * test: use RangeError * chore: var -> const * docs: add --remove to readme * chore: update bug template * chore: update mod template * test: migrate to ava, snapshots * refactor: ES6 all the things * feat: add skipLines option (#64) * skips setting header row unti a specified string is found in the cells * only emit(this._Row, cells) if it's not the first row * update README to show skipUntil option * update README to show skipUntil option * update README.md [remove extra comma] * fix tests * skipUntil skips setting headers until line number is reached * update readme to show that skipUntil takes a line number int * remove extra blank line * change name of skipUntil opt to skipLines * add cli flags for skipLines * remove extra blank line in junk_rows.csv * update README.md with CLI flag for skipLines * chore: alphabetize option in README * chore: alphabetize CLI flag * chore: update flag description in CLI * zero indexed skipLines * update test to ava * fix test errors * chore: alphabetize, use string literals * feat: allow headers: false, index column names * chore: remove tape dependency * docs: add headers:false output example * chore(release): 2.0.0-beta.0 * chore: better benchmark profiling * docs: add benchmarks * chore: add files to package.json to reduce tarball size * feat: provide header, index to mapValues and mapHeaders * chore(release): 2.0.0-beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the name of the error that the parser emits from the default of
ErrortoSyntaxError. This makes it easier for users to distinguish parsing errors from other error types. This also makes the parser behave more likeJSON.parse(), which emits aSyntaxErrorwhen it encounters invalid JSON.See the following for details on
Error.name:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/name