Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use safe-buffer module to make Buffer.from() available in old versions of Node.js #18

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link

@Trott Trott commented Mar 21, 2018

No description provided.

@Trott
Copy link
Author

Trott commented Mar 21, 2018

(Happy to modify it so it only touches the tests if you'd prefer to not add a module to the actual library code, since there's already code in there to avoid Buffer constructor if Buffer.from() exists.)

@ChALkeR
Copy link
Contributor

ChALkeR commented Mar 21, 2018

@Trott I specifically patched this in #17 without extra deps.

A one-liner shouldn't require an extra dependency.
Perhaps move that to dev deps only, if it's required for tests? (And leave index.js as-is).

@Trott
Copy link
Author

Trott commented Mar 21, 2018

@ChALkeR Sure, done.

@Trott
Copy link
Author

Trott commented Jul 12, 2018

I think since #17 landed, this is obsolete but if I'm mistaken, by all means, re-open.

@Trott Trott closed this Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants