-
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded to electron 1.4.12 #125
base: master
Are you sure you want to change the base?
Conversation
var shell = require('shell') | ||
var powerSaveBlocker = require('electron').powerSaveBlocker | ||
var globalShortcut = require('electron').globalShortcut | ||
const |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this, much appreciated.
Can you follow the code patterns that's already being used. Mainly that we use var
and not const/let
.
win = new BrowserWindow({ | ||
title: 'playback', | ||
width: 860, | ||
height: 470, | ||
frame: frame, | ||
frame: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What has changed since you removed the platform check?
@@ -1,12 +1,11 @@ | |||
const {remote, ipcRenderer} = require('electron'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const
-> var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and no ;
:)
No description provided.