Update all dependencies #190

G-Ray · 2018-11-21T22:34:59Z

I updated all the dependencies to the latest version.

torrent-discovery's api has changed a bit, do not hesitate to request changes if necessary.

G-Ray · 2018-11-21T22:37:14Z

index.js

@@ -779,7 +783,6 @@ var torrentStream = function (link, opts, cb) {
    if (!port) return findPort(opts.port || DEFAULT_PORT, cb)
    engine.port = port
    swarm.listen(engine.port, cb)
-    discovery.updatePort(engine.port)


I removed this line, it should not be necessary right ?

The discovery needs to announce the same port, is that done somewhere else now?

G-Ray · 2018-11-22T09:09:18Z

@mafintosh

mafintosh · 2018-12-05T09:44:56Z

Awesome stuff @G-Ray - See my one comment

G-Ray · 2018-12-05T09:48:43Z

index.js

+      peerId: bufferFrom(opts.id),
+      dht: (opts.dht !== undefined) ? opts.dht : true,
+      tracker: (opts.tracker !== undefined) ? opts.tracker : true,
+      port: engine.port || DEFAULT_PORT,


It should be done here right ?

G-Ray · 2019-12-22T20:10:39Z

I just re-updated this with the very latest deps. node >= 10 is now required due to bitfield v3.0.0. If you prefer to still support node < 10 we should keep using bitfield 2.x.

G-Ray · 2019-12-22T20:34:38Z

test/auto-block.js

@@ -21,7 +21,7 @@ test('fixture can verify the torrent', function (t) {
  t.plan(2)
  fixture.on('ready', function () {
    t.ok(true, 'seed should be ready')
-    t.deepEqual(fixture.bitfield.buffer.toString('hex'), 'c0', 'should verify all the pieces')
+    t.deepEqual(fixture.bitfield.buffer[0], 192, 'should verify all the pieces')


bitfield >= 3 should support node 8, but on travis we get

---expected +++ actual @@ -1,1 +1,1 @@ -192 +0 test: test/auto-block.js fixture can verify the torrent stack: | Object.<anonymous> (test/auto-block.js:24:7) index.js:568:16

pataquets · 2020-11-04T23:29:27Z

Looks like this PR stalled. Although some dependencies are again outdated, if the effort invested is significant, I would merge this if possible and update again in another PR.
@G-Ray : Are you still interested/able to push it forward? Do you have the bandwidth and/or interest on it? No obligation, just wanting to make it obvious in case someone wants to pick it up. It would be a shame to lose all the time and effort put here.

G-Ray · 2020-11-11T14:56:22Z

Looks like this PR stalled. Although some dependencies are again outdated, if the effort invested is significant, I would merge this if possible and update again in another PR.
@G-Ray : Are you still interested/able to push it forward? Do you have the bandwidth and/or interest on it? No obligation, just wanting to make it obvious in case someone wants to pick it up. It would be a shame to lose all the time and effort put here.

Thank you @pataquets for your interest in this Pull Request ! 🤗
Unfortunately, I don't have enough bandwidth to update this PR these times. Feel free to fork my branch and reopen a PR, or I can give you write access to my fork to update this one.

pataquets · 2020-11-11T17:18:20Z

Fair enough. Thanks for the heads up, @G-Ray.
Unfortunately, I don't have the skills to pick this up, but it will be useful to know, no doubt. I would like to ask you to not delete your branch, in case anyone capable can pick it up.
I was interested since a project I use depended on it: https://github.com/KiraLT/torrent-stream-server .
However, since there are some security issues due to outdated modules, the above project switched to webtorrent, which is actively maintained.
Just FYI (or anyone else interested).
Thanks again for your work and time.
cc: @mafintosh

mafintosh · 2020-11-11T20:29:27Z

Using webtorrent makes sense 👍

pataquets · 2020-11-11T21:31:12Z

Thanks @mafintosh . In case you don't have interest or bandwidth for maintaining the project, may I suggest you to post a notice in the main readme?
Also, there's an interesting website I have discovered recently which might come handy, just in case: https://adoptoposs.org/

G-Ray commented Nov 21, 2018

View reviewed changes

G-Ray commented Dec 5, 2018

View reviewed changes

G-Ray mentioned this pull request Feb 5, 2019

Update torrent-discovery Dependency #191

Open

G-Ray force-pushed the update-deps branch from fa97c3b to bf0992d Compare December 22, 2019 20:05

Update all dependencies

d55d58b

G-Ray force-pushed the update-deps branch from bf0992d to d55d58b Compare December 22, 2019 20:06

G-Ray force-pushed the update-deps branch from 9c56e89 to 171813d Compare December 22, 2019 20:29

Run tests with node >= 10

7757d04

G-Ray force-pushed the update-deps branch from 171813d to 7757d04 Compare December 22, 2019 20:30

G-Ray commented Dec 22, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update all dependencies #190

Update all dependencies #190

G-Ray commented Nov 21, 2018

G-Ray Nov 21, 2018

mafintosh Dec 5, 2018

G-Ray commented Nov 22, 2018

mafintosh commented Dec 5, 2018

G-Ray Dec 5, 2018

G-Ray commented Dec 22, 2019 •

edited

Loading

G-Ray Dec 22, 2019

pataquets commented Nov 4, 2020

G-Ray commented Nov 11, 2020

pataquets commented Nov 11, 2020

mafintosh commented Nov 11, 2020

pataquets commented Nov 11, 2020

Update all dependencies #190

Are you sure you want to change the base?

Update all dependencies #190

Conversation

G-Ray commented Nov 21, 2018

G-Ray Nov 21, 2018

Choose a reason for hiding this comment

mafintosh Dec 5, 2018

Choose a reason for hiding this comment

G-Ray commented Nov 22, 2018

mafintosh commented Dec 5, 2018

G-Ray Dec 5, 2018

Choose a reason for hiding this comment

G-Ray commented Dec 22, 2019 • edited Loading

G-Ray Dec 22, 2019

Choose a reason for hiding this comment

pataquets commented Nov 4, 2020

G-Ray commented Nov 11, 2020

pataquets commented Nov 11, 2020

mafintosh commented Nov 11, 2020

pataquets commented Nov 11, 2020

G-Ray commented Dec 22, 2019 •

edited

Loading