Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid disabling of hook on log #43

Closed
wants to merge 1 commit into from
Closed

Avoid disabling of hook on log #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@ module.exports = whyIsNodeRunning
function whyIsNodeRunning (logger) {
if (!logger) logger = console

hook.disable()
logger.error('There are %d handle(s) keeping the process running', active.size)
for (const o of active.values()) printStacks(o)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this change needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I'm not really sure anymore. Given that printStacks is synchronous, I would assume it to make absolutely no difference because of the single-threaded nature, but I somehow distinctly remember that it did. I'm no longer working on the same project, so I unfortunately can't reproduce it.

for (const o of [...active.values()]) printStacks(o)

function printStacks (o) {
var stacks = o.stacks.slice(1).filter(function (s) {
Expand Down