Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dy] Optimize pipeline schedule queries #4188

Merged
merged 2 commits into from
Feb 2, 2024
Merged

[dy] Optimize pipeline schedule queries #4188

merged 2 commits into from
Feb 2, 2024

Conversation

dy46
Copy link
Contributor

@dy46 dy46 commented Dec 15, 2023

Description

Optimize some schedule queries. Some queries were pulling all pipeline runs for a schedule when they just needed to get a count which could be very inefficient when there are a lot of runs.

How Has This Been Tested?

  • Tested locally
  • Unit tests

Checklist

  • The PR is tagged with proper labels (bug, enhancement, feature, documentation)
  • I have performed a self-review of my own code
  • I have added unit tests that prove my fix is effective or that my feature works
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • If new documentation has been added, relative paths have been added to the appropriate section of docs/mint.json

cc: @wangxiaoyou1993

@dy46 dy46 added the enhancement Polish or UX improvements label Dec 15, 2023
@dy46 dy46 changed the title [dy] Update 1 more query [dy] Update should_schedule search query Dec 15, 2023
@dy46 dy46 changed the title [dy] Update should_schedule search query [dy] Optimize pipeline schedule queries Jan 11, 2024
Copy link
Member

@wangxiaoyou1993 wangxiaoyou1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after rebase master branch

@dy46 dy46 merged commit a7a88c8 into master Feb 2, 2024
9 checks passed
@dy46 dy46 deleted the dy--update_queries_p2 branch February 2, 2024 17:48
@wangxiaoyou1993 wangxiaoyou1993 mentioned this pull request Feb 7, 2024
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Polish or UX improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants