Remove Sitemap class override, added plugin instead

magefan · Jul 2, 2017 · 8b2fda4 · Koc · Jul 10, 2017 · 8b2fda4
1 parent f423b0b
commit 8b2fda4
Show file tree

Hide file tree

Showing 3 changed files with 76 additions and 1 deletion.
diff --git a/Model/Sitemap.php b/Model/Sitemap.php
@@ -21,6 +21,7 @@ class Sitemap extends \Magento\Sitemap\Model\Sitemap
     protected function _initSitemapItems()
     {
         parent::_initSitemapItems();
+        $this->_sitemapItems = [];
 
         $this->_sitemapItems[] = new \Magento\Framework\DataObject(
             [
@@ -47,4 +48,13 @@ protected function _initSitemapItems()
         );
     }
 
+    /**
+     * Disable save action
+     * @return sekf
+     */
+    public function save()
+    {
+        return $this;
+    }
+
 }
diff --git a/Plugin/Magento/Sitemap/SitemapPlugin.php b/Plugin/Magento/Sitemap/SitemapPlugin.php
@@ -0,0 +1,60 @@
+<?php
+/**
+ * Copyright © 2015-2017 Ihor Vansach (ihor@magefan.com). All rights reserved.
+ * See LICENSE.txt for license details (http://opensource.org/licenses/osl-3.0.php).
+ *
+ * Glory to Ukraine! Glory to the heroes!
+ */
+
+namespace Magefan\Blog\Plugin\Magento\Sitemap;
+
+/**
+ * Plugin for sitemap generation
+ */
+class SitemapPlugin
+{
+    /**
+     * @var \Magefan\Blog\Model\SitemapFactory
+     */
+    protected $sitemapFactory;
+
+    /**
+     * Generated sitemaps
+     * @var array
+     */
+    protected $generated = [];
+
+    public function __construct(
+        \Magefan\Blog\Model\SitemapFactory $sitemapFactory
+    ) {
+        $this->sitemapFactory = $sitemapFactory;
+    }
+
+    /**
+     * Add magefan blog actions to allowed list
+     * @param  \Magento\Sitemap\Model\Sitemap $sitemap
+     * @return array
+     */
+    public function afterGenerateXml(\Magento\Sitemap\Model\Sitemap $sitemap, $result)
+    {
+        $sitemapId = $sitemap->getId() ?: 0;
+        if (in_array($sitemapId, $this->generated)) {
+            return $result;
+        }
+        $this->generated[] = $sitemapId;
+
+        $blogSitemap = $this->sitemapFactory->create();
+        $blogSitemap->setData(
+            $sitemap->getData()
+        );
+
+        $blogSitemap->setSitemapFilename(
+            'blog_' . $sitemap->getSitemapFilename()
+        );
+
+        $blogSitemap->generateXml();
+
+        return $result;
+    }
+
+}
diff --git a/etc/di.xml b/etc/di.xml
@@ -10,7 +10,7 @@
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
     <preference for="Magefan\Blog\Api\PostManagementInterface" type="Magefan\Blog\Model\PostManagement" />
     <preference for="Magefan\Blog\Api\CategoryManagementInterface" type="Magefan\Blog\Model\CategoryManagement" />
-    <preference for="Magento\Sitemap\Model\Sitemap" type="Magefan\Blog\Model\Sitemap" />
+    <!-- deprecated <preference for="Magento\Sitemap\Model\Sitemap" type="Magefan\Blog\Model\Sitemap" /> -->
     <virtualType name="Magefan\Blog\ImageUpload" type="Magento\Catalog\Model\ImageUploader">
         <arguments>
             <argument name="baseTmpPath" xsi:type="string">magefan_blog/tmp</argument>
@@ -47,4 +47,9 @@
         <plugin name="plumrocket_amp_source_page_magefan_blog"
                 type="Magefan\Blog\Plugin\Plumrocket\Amp\SourcePagePlugin" sortOrder="10"/>
     </type>
+
+    <type name="Magento\Sitemap\Model\Sitemap">
+        <plugin name="magento_sitemap_model_sitemap_magefan_blog"
+                type="Magefan\Blog\Plugin\Magento\Sitemap\SitemapPlugin" sortOrder="10"/>
+    </type>
 </config>