Fixed customer data sometimes not being cleared when logging in as customer #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nntoan
reviewed
Mar 29, 2018
| @@ -5,18 +5,15 @@ | |||
| * | |||
| * Glory to Ukraine! Glory to the heroes! | |||
| */ | |||
| /** @var \Magento\Framework\View\Element\Template $block */ | |||
There was a problem hiding this comment.
@erfanimani Can you please use the equivalent block class name instead? Otherwise, it looks really good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also gets rid of the unnecessary 5 second delay.
The particular bug that this fixes, happens when you navigate away before the 5 second redirect.
I'll be rolling this to my staging environment soon, so I will let you know how it goes. Any comments, improvements welcome.
CC @nntoan @magefan