Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dungeon, Ring and other inner token images in Command Zone as information objects #12274

Open
Grath opened this issue May 22, 2024 · 2 comments
Open

Add Dungeon, Ring and other inner token images in Command Zone as information objects #12274

Grath opened this issue May 22, 2024 · 2 comments
Assignees
@JayDi85
Labels
bug Bugs and errors enhancement GUI

Comments

@Grath
Copy link
Contributor

Grath commented May 22, 2024

The images show up in the card viewer, but they don't actually properly render when the objects are created in the command zone.
@Grath Grath added the GUI label May 22, 2024
@JayDi85 JayDi85 changed the title Dungeon and Ring tokens don't show images in the Command Zone Add Dungeon, Ring and other inner token images in Command Zone as information objects May 22, 2024
@JayDi85 JayDi85 added the bug Bugs and errors label May 23, 2024
@JayDi85
Copy link
Member

JayDi85 commented May 23, 2024

Stack object miss set info:

missing_img

@Grath
Copy link
Contributor Author

Grath commented May 23, 2024

Same with the objects that get placed in the Command Zone. Looks like they used to have the set information provided, but this was removed in f2d93f2 - since The Ring emblem and the dungeons aren't directly created by cards, that change might need to be reverted for these to work properly?

@JayDi85 JayDi85 self-assigned this Sep 19, 2024
JayDi85 added a commit that referenced this issue Sep 19, 2024
@JayDi85
Dungeon improves:
b40e722 
* Dungeons: added dungeon name hint to room's game log and choices (part of #12274);
* GUI, game: added card popup hints support in feedback panel (yes/no choices);
* Images: fixed miss images for dungeons in command zone, game logs and choice dialogs;
JayDi85 added a commit that referenced this issue Sep 20, 2024
@JayDi85
images: fixed wrong miss image message in card hints for dungeons and…
e1ab0be 
… other command objects (part of #12274);
JayDi85 added a commit that referenced this issue Sep 20, 2024
@JayDi85
Venture into abilities - added card hints about current dungeon and r…
bf2c4ca 
…oom (part of #12274);
JayDi85 added a commit that referenced this issue Sep 21, 2024
@JayDi85
images: added The Ring image support (part of #12274, #12899);
f7d702d 
images: fixed miss dungeon image in choose dungeon dialog (part of #12274);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayDi85 JayDi85

Labels
bug Bugs and errors enhancement GUI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Grath @JayDi85