Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SVG icons support #4196

Closed
10 of 15 tasks
JayDi85 opened this issue Nov 24, 2017 · 0 comments
Closed
10 of 15 tasks

Add SVG icons support #4196

JayDi85 opened this issue Nov 24, 2017 · 0 comments
Assignees
@JayDi85
Labels
download enhancement GUI tracking tasks Todo list for big tasks

Comments

@JayDi85
Copy link
Member

JayDi85 commented Nov 24, 2017 •
edited
Loading

Wizard's symbols in gif format is weird. It have many artefacts:

shot_171124_155532

XMage must use SVG symbols. Scryfall have it. What need to do:

  • add svg library support for images loading;
  • new render for mana icons in cards;
  • new render for mana icons in tables;
  • new render for mana icons in other windows (hints, info);
  • support empty images draw (mana text instead images);
  • support pnp generation from svg (for html texts)
  • add svg symbols downloading from scryfall (not so easy, need parse, API is not support it yet);
  • test new svg version in linux machines (can it draw svg correct?);
  • check and change symbols sizes and position (some old symbols load by image offsets, old images have "border space" and so on);
  • fix bug with image downloading (after download images is not reloading from disk);
  • add option to draw mana cost with shadow;
  • mana icons in card hints and test errors (see Error when hovering over cards #4278);
  • fix mana icons on card's hint (replace orbs with mana)
  • fix mana icons in player's badges on:
    shot_171227_061335
  • fix windows 10 svg errors;

I'm work on that issue.

Some results:
mtg - svg -render example

shot_171125_170837

shot_171126_190952
@JayDi85 JayDi85 self-assigned this Nov 24, 2017
@JayDi85 JayDi85 mentioned this issue Nov 26, 2017
Merged
@JayDi85 JayDi85 added the tracking tasks Todo list for big tasks label Jan 15, 2018
@JayDi85 JayDi85 closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JayDi85 JayDi85

Labels
download enhancement GUI tracking tasks Todo list for big tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JayDi85