Svg mana icons support #4203
Merged
Svg mana icons support #4203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete duplicate consts; - correct paths and it uses; - fix loading icons from user defined dir;
sync source
- Added new images and symbols downloading; - Fixed user defined images path (now work for all images: cards, symbols, temp downloading); - Fixed not working cancel button at download window (it close window, but tasks is working, download and didn't save); - Fixed temp files trash all around images folder (on cancel button); - Fixed not saving new downloaded cards on cancel button (zip file didn't close on cancel);
|
Test version with svg symbols support is done. You can download basic mana symbols here: svg_symbols.zip (extract archive to Also you can download:
|
|
^^ The mana cost is missing the shadow. Mana symbols in the rules text are flat like that but not in the casting cost |
|
@spjspj I'll look on shadow option for draw method later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of svg support (look at issue #4196 for more info).
What was done:
What's need to do for second part:
You can download basic mana symbols here: svg_symbols.zip (extract archive to
Mage.Client\plugins\images\symbols\).