Improvements to player selection of TargetAmount #11341
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when
getMultiAmount()
is called withinHumanPlayer::chooseTargetAmount
it enforces the minimum of 1 per target to comply with CR 601.2d:chooseTargetAmount()
now also prevents a human player from choosing more targets than the amount to be divided.The spinners in
PickMultiNumberDialog
now start at the minimum. So when distributing among targets, they start out at 1 for each target.The effects that call
getMultiAmount()
for adding mana in some combination of colors now explicitly set the minimum to 0 so they continue to work correctly.Furthermore, for UX improvement, the
PickMultiNumberDialog
is bypassed when there is only one possible choice:Resolves #9379.