Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked GUI to support non-blocking UI and background download #12825

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

JayDi85
Copy link
Member

@JayDi85 JayDi85 commented Sep 7, 2024

Modal dialogs are special dialogs with exclusive focus. User can't clicks/press outside of the "window". Most required dialogs in xmage are modal, e.g. user must make a choice before continue. It's make dev life easy (no need in sync code) but has some limitations and other problems (see related issues below).

New system removed all modals (except few windows like Preferences) -- now it use non-blocking dialogs with callbacks. Dev must sync and control dialogs usage (create, show, process results and cleanup resources on close).

Full changes list:

- GUI: added non-blocking UI to almost all app and game dialogs;
- GUI: it allows to switch between UI dialogs and use any UI elements at any moment;
- GUI: it allows to use chat, card popup, battlefield, concede and other features while choosing (related to #12670);
- GUI: it allows to download images while playing (related to #4160, not fully tested);
- GUI: enabled by default, can be disabled by java option: -Dxmage.guiModalMode=true
- connection: auto-connect will be visible in main menu on startup;
- connection: removed some unused features (auto-connect by command line);
- connection: added <ESC> button to close connection dialog;
- download: added background images download (see non-blocking UI);
- download: improved cancel stability and fixes that it can't stop preparing/downloading process in some use cases;
- app: fixed freezes on macOS systems in some use cases (related to #12431, #11292, #9300, #4920);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant