Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keywords field to the edit image description slide panel #1515

Closed
sivaschenko opened this issue Jun 23, 2020 · 2 comments · Fixed by #1605
Closed

Add keywords field to the edit image description slide panel #1515

sivaschenko opened this issue Jun 23, 2020 · 2 comments · Fixed by #1605
Assignees
@joweecaquicla
Labels
Frontend/UI Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Milestone
2.1.0

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Jun 23, 2020 •
edited
Loading

Story: #724

Preconditions (*)

  1. Install Magento 2.4-develop with Adobe Stock 2.0-develop
  2. Enable Enhanced Media Gallery in the configuration
  3. Have an image uploaded to the media gallery

Steps to reproduce (*)

  1. Login to admin panel
  2. Open media gallery (I.e. Content -> Media Gallery menu)
  3. Open context menu for the image by clicking on three dots next to the image in the grid
  4. Select "Edit" option to open the Edit image details slide panel

Expected result (*)

A popup appears with a warning message showing the content usage information for the selected assets

Expected result (*)

Keywords filed is present in the slide panel

image
@sivaschenko sivaschenko added this to the 2.1.0 milestone Jun 23, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2020

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this

@sluggishlance sluggishlance self-assigned this Jun 29, 2020
sluggishlance pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 7, 2020
@LanceATF
magento#1515: Add keywords field to the edit image description slide …
dcda358 
…panel - Added multiselect field for keywords and adjusted Edit Details fieldset DOM to make use of native css form styles
@sluggishlance sluggishlance mentioned this issue Jul 7, 2020
Closed
@joweecaquicla
Copy link

@magento I am working on this

joweecaquicla pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 10, 2020
magento#1515: Add keywords field to the edit image description slide …
283c61d 
…panel - pulled the save keywords of images with keywords and had it displayed when opening edit panel
joweecaquicla pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 15, 2020
magento#1515: Add keywords field to the edit image description slide …
49b4872 
…panel - fixed merge conflict
joweecaquicla pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 15, 2020
magento#1515: Add keywords field to the edit image description slide …
3fc6e00 
…panel - fix merge conflict
joweecaquicla pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 15, 2020
magento#1515: Add keywords field to the edit image description slide …
94cc75b 
…panel - fix merge conflict
joweecaquicla pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 15, 2020
magento#1515: Add keywords field to the edit image description slide …
af61a90 
…panel - fix merge conflict
joweecaquicla pushed a commit to sluggishlance/adobe-stock-integration that referenced this issue Jul 15, 2020
magento#1515: Add keywords field to the edit image description slide …
b1c9cda 
…panel - modifications for keywords field and saving of keywords from edit image panel
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 16, 2020
magento#1515: Add keywords field to the edit image description slide …
84de736 
…panel - initial implementation of ui-select for keywords field
@joweecaquicla joweecaquicla mentioned this issue Jul 16, 2020
Merged
@joweecaquicla joweecaquicla linked a pull request Jul 16, 2020 that will close this issue
#1515: Add keywords field to the edit image description slide panel #1605
Merged
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 17, 2020
magento#1515: Add keywords field to the edit image description slide …
507f503 
…panel - added keyword-ui-select as child component of image-edit, export image to keyword-ui-select, and modified getkeywordsop logic
joweecaquicla pushed a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 17, 2020
magento#1515: Add keywords field to the edit image description slide …
b3baefd 
…panel - modified getkeywordsop logic
sivaschenko added a commit to joweecaquicla/adobe-stock-integration that referenced this issue Jul 26, 2020
@sivaschenko
magento#1515: MFTF test coverage
daa221f
@sivaschenko sivaschenko added Priority: P1 Needs to be fixed before any other issues Severity: S1 Affects critical data or functionality and forces users to employ a workaround labels Jul 29, 2020
sivaschenko added a commit that referenced this issue Aug 2, 2020
@sivaschenko
Merge pull request #1605 from joweecaquicla/1515-add-keywords-field-t…
fa4c4f2 
…o-edit-image

#1515: Add keywords field to the edit image description slide panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joweecaquicla joweecaquicla

Labels
Frontend/UI Priority: P1 Needs to be fixed before any other issues Progress: done Severity: S1 Affects critical data or functionality and forces users to employ a workaround
Projects
None yet
Milestone
2.1.0
3 participants
@sivaschenko @joweecaquicla @sluggishlance