Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added metadata integration tests #1560

Merged

Conversation

sivaschenko
Copy link
Member

@sivaschenko sivaschenko commented Jul 4, 2020

Added metadata integration tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

sivaschenko commented Jul 5, 2020

@Nazar65 I believe the new XMP segment creation for JPEG should work fine on this PR. However, we'll need to adjust or add specific test to check each format (as for example, XMP data is added to iptc_only image and the verification is not identifying if the data was retrieved from XMP or IPTC)

@sivaschenko
Copy link
Member Author

Integration tests console log contains two fatal errors:

PHP Fatal error:  Uncaught InvalidArgumentException: Invalid scope type 'stores' in /var/www/html/lib/internal/Magento/Framework/App/ScopeResolverPool.php:40
15:15:50 [Integration-13-ee] Stack trace:
15:15:50 [Integration-13-ee] #0 /var/www/html/lib/internal/Magento/Framework/App/Config/ScopeCodeResolver.php(48): Magento\Framework\App\ScopeResolverPool->get()
15:15:50 [Integration-13-ee] #1 /var/www/html/dev/tests/integration/framework/Magento/TestFramework/App/Config.php(80): Magento\Framework\App\Config\ScopeCodeResolver->resolve()
15:15:50 [Integration-13-ee] #2 /var/www/html/dev/tests/integration/framework/Magento/TestFramework/App/MutableScopeConfig.php(50): Magento\TestFramework\App\Config->setValue()
15:15:50 [Integration-13-ee] #3 /var/www/html/dev/tests/integration/framework/Magento/TestFramework/Annotation/ConfigFixture.php(118): Magento\TestFramework\App\MutableScopeConfig->setValue()
15:15:50 [Integration-13-ee] #4 /var/www/html/dev/tests/integration/framework/Magento/TestFramework/Annotation/ConfigFixture.php(95): Magento\TestFramework\Annotation\ConfigFixture->setScopeConfigValue()
15:15:50 [Integration-13-ee] #5 /var/www/html/dev/tests/integration/framework/Magento/TestFramework/Annotation/ConfigFixture.php(186 in /var/www/html/lib/internal/Magento/Framework/App/ScopeResolverPool.php on line 40
PHP Fatal error:  Uncaught Error: Cannot instantiate interface Magento\Framework\Interception\PluginListInterface in /var/www/html/lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php:121
15:19:47 [Integration-14-ee] Stack trace:
15:19:47 [Integration-14-ee] #0 /var/www/html/lib/internal/Magento/Framework/ObjectManager/Factory/Compiled.php(108): Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject()
15:19:47 [Integration-14-ee] #1 /var/www/html/lib/internal/Magento/Framework/ObjectManager/ObjectManager.php(70): Magento\Framework\ObjectManager\Factory\Compiled->create()
15:19:47 [Integration-14-ee] #2 /var/www/html/lib/internal/Magento/Framework/Interception/Interceptor.php(42): Magento\Framework\ObjectManager\ObjectManager->get()
15:19:47 [Integration-14-ee] #3 /var/www/html/dev/tests/integration/tmp/sandbox--76ccf56fc1cd540134f59b4069e60caaa4132cb3976271c3398ab8e1c4c45409/generated/code/Magento/Config/Model/ResourceModel/Config/Data/Collection/Interceptor.php(13): Magento\Config\Model\ResourceModel\Config\Data\Collection\Interceptor->___init()
15:19:47 [Integration-14-ee] #4 /var/www/html/lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php in /var/www/html/lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php on line 121

@sivaschenko
Copy link
Member Author

Failed testsuites:

<testsuites>
<testsuite name="Magento Integration Tests ee 13-2">
<file>testsuite/Magento/IntegrationTest.php</file>
</testsuite>
<testsuite name="Magento Integration Tests Real Suite">
<file>testsuite/Magento/Framework/Console/CliTest.php</file>
<file>testsuite/Magento/Framework/Css/PreProcessor/Adapter/CssInlinerTest.php</file>
<file>testsuite/Magento/Framework/Css/PreProcessor/File/Collector/AggregatedTest.php</file>
<file>testsuite/Magento/Framework/DB/Adapter/InterfaceTest.php</file>
<file>testsuite/Magento/Framework/DB/Adapter/Pdo/MysqlTest.php</file>
<file>testsuite/Magento/Framework/DB/DataConverter/DataConverterTest.php</file>
<file>testsuite/Magento/Framework/DB/HelperTest.php</file>
<file>testsuite/Magento/Framework/DB/TransactionTest.php</file>
<file>testsuite/Magento/Framework/Data/Argument/Interpreter/BaseStringUtilsTest.php</file>
<file>testsuite/Magento/Framework/Data/Argument/Interpreter/StringUtilsTest.php</file>
<file>testsuite/Magento/Framework/Data/Form/Element/DateTest.php</file>
<file>testsuite/Magento/Framework/Data/Form/Element/FieldsetTest.php</file>
<file>testsuite/Magento/Framework/Data/Form/Element/ImageTest.php</file>
<file>testsuite/Magento/Framework/Data/Wysiwyg/NormalizerTest.php</file>
</testsuite>
</testsuites>
<testsuites>
<testsuite name="Magento Integration Tests ee 14-3">
<file>testsuite/Magento/IntegrationTest.php</file>
</testsuite>
<testsuite name="Magento Integration Tests Real Suite">
<file>testsuite/Magento/Framework/ObjectManager/Factory/CompiledTest.php</file>
<file>testsuite/Magento/Framework/ObjectManager/Factory/Dynamic/DeveloperTest.php</file>
<file>testsuite/Magento/Framework/ObjectManager/ObjectManagerTest.php</file>
<file>testsuite/Magento/Framework/Pricing/Helper/DataTest.php</file>
<file>testsuite/Magento/Framework/Profiler/Driver/Standard/Output/CsvfileTest.php</file>
<file>testsuite/Magento/Framework/Profiler/Driver/Standard/Output/HtmlTest.php</file>
<file>testsuite/Magento/Framework/ProfilerTest.php</file>
<file>testsuite/Magento/Framework/Reflection/MethodsMapTest.php</file>
<file>testsuite/Magento/Framework/Search/Request/Config/ConverterTest.php</file>
<file>testsuite/Magento/Framework/Search/Request/Config/FileSystemReaderTest.php</file>
<file>testsuite/Magento/Framework/Search/Request/MapperTest.php</file>
<file>testsuite/Magento/Framework/Session/Config/Validator/CookieDomainValidatorTest.php</file>
<file>testsuite/Magento/Framework/Session/Config/Validator/CookieLifetimeValidatorTest.php</file>
<file>testsuite/Magento/Framework/Session/Config/Validator/CookiePathValidatorTest.php</file>
</testsuite>
</testsuites>

@sivaschenko
Copy link
Member Author

sivaschenko commented Jul 6, 2020

\Magento\Framework\ObjectManager\Factory\Dynamic\DeveloperTest or CompitledTest fail if it is executed as the first test in the suite

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko
Copy link
Member Author

@magento run all tests

@sivaschenko sivaschenko merged commit 07d2981 into magento:2.0-develop Jul 7, 2020
@ghost
Copy link

ghost commented Jul 7, 2020

Hi @sivaschenko, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant