Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce asset filter for Category grid, Page Blocks and product grid #1587

Merged
merged 30 commits into from
Jul 20, 2020
Merged

Introduce asset filter for Category grid, Page Blocks and product grid #1587

merged 30 commits into from
Jul 20, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jul 9, 2020 •
edited by sivaschenko
Loading

Fixed Issues (if relevant)

  1. Fixes Add asset filter to category grid #1502: add asset filter to category grid
  2. Fixes Add media asset filter to the product grid #1479 Add media asset filter to the product grid
  3. Fixes Add Media Asset filter to Cms page and block grids #1480 Add Media Asset filter to Cms page and block grids

Manual testing scenarios (*)

1.Open Category grid page by link admin/media_gallery_catalog/category/index
2. Expand Filters tab
3. Put asset path in Asset filter input
4. Same for product grid , pages grid , blocks grid

Screenshot_2020-07-10 Categories Magento Admin

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 9, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 9, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 9, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 10, 2020

@magento run all tests

@Nazar65 Nazar65 mentioned this pull request Jul 10, 2020
Merged
4 tasks
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 10, 2020

@magento run all tests

@Nazar65 Nazar65 changed the title Introduce asset filter for Category grid Introduce asset filter for Category grid, Page Blocks and product grid Jul 10, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 10, 2020

@magento run all tests

@Nazar65 Nazar65 added the MFTF tests MFTF tests coverage label Jul 13, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 13, 2020

@magento run all tests

1 similar comment
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 13, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 13, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 14, 2020

@magento run all tests

@sivaschenko sivaschenko mentioned this pull request Jul 14, 2020
Closed
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 16, 2020

@magento run all tests

@chalov-anton
Copy link
Contributor

✔️ Great job

The Asset filter works on: Product, Page, Category, and Blocks pages.
Added a scenario to Regression Scope - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4951024

@sivaschenko sivaschenko merged commit 78116d4 into magento:2.0-develop Jul 20, 2020
@ghost
Copy link

ghost commented Jul 20, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@gabrieldagama gabrieldagama

Labels
MFTF tests MFTF tests coverage
Projects
None yet
Milestone
No milestone
4 participants
@Nazar65 @chalov-anton @sivaschenko @gabrieldagama