Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Not used anywhere" option to the Used In filter #1601

Merged
merged 10 commits into from
Jul 21, 2020
Merged

Add "Not used anywhere" option to the Used In filter #1601

merged 10 commits into from
Jul 21, 2020

Conversation

Nazar65
Copy link
Member

@Nazar65 Nazar65 commented Jul 16, 2020

Description (*)

This PR adds ability to search images thats not used anywhere

Fixed Issues (if relevant)

  1. Fixes Add "Not used anywhere" option to the Used In filter #1489: Add "Not used anywhere" option to the Used In filter

Manual testing scenarios (*)

  1. Open enhanced media gallery
  2. Expand filters section
  3. Apply used in filter with Not used anywhere option

Discover images that's are not used anywhere

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 16, 2020

@magento run all tests

@sivaschenko
Copy link
Member

@Nazar65 looks good, can you please add an MFTF test covering this options since it's an individual story

gabrieldagama
gabrieldagama suggested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nazar65, thanks for your PR! Please follow my comments below. Let me know if you have any questions.

MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/EntityType.php Show resolved Hide resolved
@Nazar65 Nazar65 added the MFTF tests MFTF tests coverage label Jul 16, 2020
@Nazar65
Copy link
Member Author

Nazar65 commented Jul 16, 2020

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 16, 2020

@magento run all tests

gabrieldagama
gabrieldagama suggested changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@gabrieldagama gabrieldagama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Nazar65, thanks for the updates, it looks great! Please follow some small typos and consistency comments below.

MediaGalleryUi/Model/SearchCriteria/CollectionProcessor/FilterProcessor/EntityType.php Outdated Show resolved Hide resolved
MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyNotUsedOptionFilterTest.xml Outdated Show resolved Hide resolved
MediaGalleryUi/Test/Mftf/Test/AdminEnhancedMediaGalleryVerifyNotUsedOptionFilterTest.xml Outdated Show resolved Hide resolved
sivaschenko
sivaschenko previously approved these changes Jul 21, 2020
View reviewed changes
@chalov-anton
Copy link
Contributor

✔️ QA Passed

The **Not used anywhere filter works correctly as a separate option, and together with "Pages", "Products", "Blocks", "Categories"
Added steps to the existing scenario - https://studio.cucumber.io/projects/131313/test-plan/folders/1320712/scenarios/4930844

@lenaorobei
Copy link
Contributor

@magento run all tests

@Nazar65
Copy link
Member Author

Nazar65 commented Jul 21, 2020

@magento run all tests

@lenaorobei
Copy link
Contributor

@magento run all tests

@lenaorobei lenaorobei merged commit b2e96b4 into magento:2.0-develop Jul 21, 2020
@ghost
Copy link

ghost commented Jul 21, 2020

Hi @Nazar65, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sivaschenko sivaschenko mentioned this pull request Jul 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldagama gabrieldagama gabrieldagama requested changes

@sivaschenko sivaschenko sivaschenko approved these changes

Assignees

@sivaschenko sivaschenko

@gabrieldagama gabrieldagama

Labels
MFTF tests MFTF tests coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Not used anywhere" option to the Used In filter
5 participants
@Nazar65 @sivaschenko @chalov-anton @lenaorobei @gabrieldagama