Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQl Example of adding product to cart with customizable options #4150

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Apr 3, 2019

This PR is a:

  • New topic
  • Content update
  • Content fix or rewrite
  • Bug fix or improvement

Summary

This PR introduces adds request and response examples for adding a simple product with customizable options to the shopping cart

Additional information

List all affected URLs

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar
Copy link
Contributor Author

rogyar commented Apr 11, 2019

Hi @keharper. Could you review my 2 cents when you have time, please?
Thank you!

@keharper
Copy link
Contributor

@rogyar I don't expect to merge this for another week or two. I'm in the processing of scoping the documentation impact of all PRs and issues expected to make it into the 2.3.2 release.

It would be helpful to me if you did the following:

  • Provide a link to the PR that enabled this mutation (if known)
  • Change the branch to magento:develop. The master branch is for documenting published code. develop is for future code.

@keharper keharper self-assigned this Apr 11, 2019
@keharper keharper added Technical Updates to the code or processes that alter the technical content of the doc In progress xx2.3.2 Magento 2.3.2 changes labels Apr 11, 2019
dshevtsov and others added 11 commits April 15, 2019 16:15
Add Docfile that contatins configuration for devdocs content management
Implement rake automation to use the Docfile locally and on CICD
Add a blank line at the end of file
* Update link as current Devdoc Magento version

* update constant for url in V2.1

* Apply suggestions from code review

Slash Added in URL

Co-Authored-By: magesanjay <39721144+magesanjay@users.noreply.github.com>

* Apply suggestions from code review

Co-Authored-By: magesanjay <39721144+magesanjay@users.noreply.github.com>

* Update path urls

* Update link url for widget
@rogyar rogyar changed the base branch from master to develop April 23, 2019 10:35
@rogyar
Copy link
Contributor Author

rogyar commented Apr 23, 2019

Hi @keharper. I've created another PR to the develop branch with link to the codebase there
#4316
Closing this one. Thank you

@rogyar rogyar closed this Apr 23, 2019
@ghost
Copy link

ghost commented Apr 23, 2019

Hi @rogyar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix partners-contribution PR created by Magento partner Technical Updates to the code or processes that alter the technical content of the doc xx2.3.2 Magento 2.3.2 changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants