Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/devdocs#: Add documentation about @magentoConfigFixture annotation #5086

Merged
merged 4 commits into from
Jul 31, 2019
Merged

magento/devdocs#: Add documentation about @magentoConfigFixture annotation #5086

merged 4 commits into from
Jul 31, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Jul 31, 2019 •
edited by keharper
Loading

Purpose of this pull request

This pull request (PR) adds a documentation about @magentoConfigFixture annotation to GraphQL functional testing page.

Affected DevDocs pages

Links to Magento source code

CC: @keharper @VitaliyBoyko

Thank you!

whatsnew
Added a description of the @magentoConfigFixture annotation to the GraphQL functional testing topic.

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jul 31, 2019
rogyar
rogyar suggested changes Jul 31, 2019
View reviewed changes
guides/v2.3/graphql/functional-testing.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/functional-testing.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/functional-testing.md Outdated Show resolved Hide resolved
@rogyar rogyar added 2.3.x Magento 2.3 related changes Major Update Significant original updates to existing content Waiting for Response Waiting for response from internal/external parties labels Jul 31, 2019
@keharper keharper self-assigned this Jul 31, 2019
@keharper keharper added Community Docs impacted by community code contribution xx2.3.3 Magento 2.3.3 changes and removed Waiting for Response Waiting for response from internal/external parties 2.3.x Magento 2.3 related changes labels Jul 31, 2019
keharper
keharper requested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@keharper keharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes requested.

guides/v2.3/graphql/functional-testing.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/functional-testing.md Outdated Show resolved Hide resolved
guides/v2.3/graphql/functional-testing.md Outdated Show resolved Hide resolved
@keharper keharper self-requested a review July 31, 2019 15:30
@keharper
Copy link
Contributor

@rogyar Please give your approval.

@keharper
Copy link
Contributor

running tests

@keharper keharper merged commit 08e8e44 into magento:develop Jul 31, 2019
@ghost
Copy link

ghost commented Jul 31, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@keharper
Copy link
Contributor

Thanks @atwixfirster!

@atwixfirster
Copy link
Contributor Author

Thanks @atwixfirster!

With my pleasure, @keharper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

@keharper keharper keharper approved these changes

Assignees

@rogyar rogyar

@keharper keharper

Labels
Community Docs impacted by community code contribution Major Update Significant original updates to existing content Partner: Atwix partners-contribution PR created by Magento partner xx2.3.3 Magento 2.3.3 changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atwixfirster @devops-devdocs @keharper @rogyar @magento-engcom-team