GraphQL-429: Test coverage: nonExistentCart

magento · Mar 12, 2019 · 350d1f8 · 350d1f8
1 parent 4550597
commit 350d1f8
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 71 deletions.
diff --git a/...s/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php b/...s/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php
@@ -411,30 +411,16 @@ public function testSetBillingAddressIfCustomerIsNotOwnerOfAddress()
     public function testSetBillingAddressOnNonExistentCart()
     {
         $maskedQuoteId = 'non_existent_masked_id';
-        $query = $this->getCartQuery($maskedQuoteId);
-        $this->graphQlQuery($query, [], '', $this->getHeaderMap());
-    }
-
-    /**
-     * @param string $maskedQuoteId
-     * @return string
-     */
-    private function getCartQuery(
-        string $maskedQuoteId
-    ) : string {
-        return <<<QUERY
+        $query = <<<QUERY
 {
   cart(cart_id: "$maskedQuoteId") {
     items {
       id
-      qty
-      product {
-        sku
-      }
     }
   }
 }
 QUERY;
+        $this->graphQlQuery($query, [], '', $this->getHeaderMap());
     }
 
     /**

diff --git a/...ts/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetPaymentMethodOnCartTest.php b/...ts/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetPaymentMethodOnCartTest.php
@@ -159,30 +159,16 @@ public function testSetPaymentMethodToAnotherCustomerCart()
     public function testPaymentMethodOnNonExistentCart()
     {
         $maskedQuoteId = 'non_existent_masked_id';
-        $query = $this->getCartQuery($maskedQuoteId);
-        $this->graphQlQuery($query, [], '', $this->getHeaderMap());
-    }
-
-    /**
-     * @param string $maskedQuoteId
-     * @return string
-     */
-    private function getCartQuery(
-        string $maskedQuoteId
-    ) : string {
-        return <<<QUERY
+        $query = <<<QUERY
 {
   cart(cart_id: "$maskedQuoteId") {
     items {
       id
-      qty
-      product {
-        sku
-      }
     }
   }
 }
 QUERY;
+        $this->graphQlQuery($query, [], '', $this->getHeaderMap());
     }
 
     /**

diff --git a/...ests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetBillingAddressOnCartTest.php b/...ests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetBillingAddressOnCartTest.php
@@ -251,30 +251,16 @@ public function testSetBillingAddressFromAddressBook()
     public function testSetBillingAddressOnNonExistentCart()
     {
         $maskedQuoteId = 'non_existent_masked_id';
-        $query = $this->getCartQuery($maskedQuoteId);
-        $this->graphQlQuery($query);
-    }
-
-    /**
-     * @param string $maskedQuoteId
-     * @return string
-     */
-    private function getCartQuery(
-        string $maskedQuoteId
-    ) : string {
-        return <<<QUERY
+        $query = <<<QUERY
 {
   cart(cart_id: "$maskedQuoteId") {
     items {
       id
-      qty
-      product {
-        sku
-      }
     }
   }
 }
 QUERY;
+        $this->graphQlQuery($query);
     }
 
     /**

diff --git a/...tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetPaymentMethodOnCartTest.php b/...tests/api-functional/testsuite/Magento/GraphQl/Quote/Guest/SetPaymentMethodOnCartTest.php
@@ -133,7 +133,15 @@ public function testSetPaymentMethodToCustomerCart()
     public function testSetPaymentOnNonExistentCart()
     {
         $maskedQuoteId = 'non_existent_masked_id';
-        $query = $this->getCartQuery($maskedQuoteId);
+        $query = <<<QUERY
+{
+  cart(cart_id: "$maskedQuoteId") {
+    items {
+      id
+    }
+  }
+}
+QUERY;
         $this->graphQlQuery($query);
     }
 
@@ -166,28 +174,6 @@ private function prepareMutationQuery(
 QUERY;
     }
 
-    /**
-     * @param string $maskedQuoteId
-     * @return string
-     */
-    private function getCartQuery(
-        string $maskedQuoteId
-    ) : string {
-        return <<<QUERY
-{
-  cart(cart_id: "$maskedQuoteId") {
-    items {
-      id
-      qty
-      product {
-        sku
-      }
-    }
-  }
-}
-QUERY;
-    }
-
     /**
      * @param string $reversedQuoteId
      * @param int $customerId