magento graphql-ce#970 Cannot return several errors for one GraphQL request

[lenaorobei]

• fixed Cannot return several errors for one GraphQL request #970
• made it possible to use addError method of GraphQlInputException in order to show multiple input validation error messages.

Example:

$e = new GraphQlInputException(__('Address validation error'));
/** @var \Magento\Framework\Phrase $error */
foreach ($errors as $error) {
    $e->addError(new GraphQlInputException(__($error)));
}
throw $e;

[cpartica]

changes look good. It's a needed change

[naydav]

I prefer an immutable type of objects. We can initialization to construct. But it's a recommendation but not a requirement.

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-6118 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[TomashKhamlai]

@lenaorobei, could you provide a case where it is possible to test it? I had hopes on #961, but it is fixed now. I just wanted to verify that both data and errors arrays are present in the response body.

[ghost]

Hi @lenaorobei, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.