Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Extended product customizable options coverage #414

Merged
merged 6 commits into from
Mar 6, 2019

Conversation

rogyar
Copy link
Contributor

@rogyar rogyar commented Feb 27, 2019

Description (*)

This PR extends customizable options coverage for GraphQl and fixes existing issues with customizable options within a scope of checkout coverage.

New customizable option types coverage for Product query

  • Date
  • Time
  • Multiple select
  • Checkbox

Fixed Issues (if relevant)

  1. [Cart operations] Cannot get information about DateTime customizable option after adding product to cart #394 [Cart operations] Cannot get information about DateTime customizable option after adding product to cart

Manual testing scenarios (*)

Product query

{
  products(search: "simple") {
    items {
      name
      ... on SimpleProduct {
        options {
          option_id
          title
          ... on CustomizableCheckboxOption {
            value {
              option_type_id
              price
              price_type
              sku
              title
              sort_order
            }
          }
          ... on CustomizableMultipleOption {
            value {
              option_type_id
              price
              price_type
              sku
              title
              sort_order
            }
          }
        }
      }
    }
  }
}

@@ -323,6 +323,19 @@ type CustomizableDropDownValue @doc(description: "CustomizableDropDownValue defi
sort_order: Int @doc(description: "The order in which the option is displayed")
}

type CustomizableMultipleOption implements CustomizableOptionInterface @doc(description: "CustomizableMultipoleOption contains information about a multiselect that is defined as part of a customizable option") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little typo here "Multipole"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Good catch! :)

@ghost
Copy link

ghost commented Mar 6, 2019

Hi @rogyar, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants