Cannot return null for non-nullable field SelectedCustomizableOptionValue.sort_order and Call to a member function getPriceType() on n

[XxXgeoXxX]

Description (*)

Description #474

Manual testing scenarios (*)

Generate Customer token
Create an empty cart as Registered Customer from GraphQL Client
Perform mutation from the description

Note: Magento get custom options from frontend like mixed data [id=>string, id=>array]. That's why in graphQl query we catch error for multidimensional data(Example: checkbox).
Also 'sort_order' doesn't exist on values level.

Example for multiple data:

mutation {
    addSimpleProductsToCart(
    input: {
      cart_id: "{{cart_id}}"
      cartItems: {
        data: {
          qty: 1
          sku: "test-simple"
        }
        customizable_options: [
          {
            id: 14
            value: "[13,23]"
          }
          {
            id: 23
            value: "test"
          }
        ]
      }
    }
  )
{
    cart {
      items {
        product {
          sku
        }
        ... on SimpleCartItem {
          customizable_options {
            id
            is_required
            sort_order
          }
        }
      }
    }
  }
}

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[naydav]

Please, remove the redundant dependency

[XxXgeoXxX]

Done

[naydav]

Please, cover functionality with API-functional test

[XxXgeoXxX]

Tests were added

[naydav]

Do we need OR or AND condition?

[XxXgeoXxX]

My mistake. We need AND condition. PR was updated

[TomashKhamlai]

Hi, @XxXgeoXxX. Feel free to write me in Slack if I can be useful for you during work on this issue.

[TomashKhamlai]

When I have this product prod_opt.zip and create the empty cart as a Customer and add this product to cart by querying

mutation addSimpleProductsToCart(
  $cart_id: String!
  $qty: Float!
  $sku: String!
) {
  addSimpleProductsToCart(
    input: {
      cart_id: $cart_id
      cartItems: {
        customizable_options: [
          {
            id: 1
            value: "[1]"
          }
          {
            id: 2
            value: "4"
          }
          {
            id: 3
            value: "7"
          }
          {
            id: 4
            value: "[10]"
          }
        ]
        data: {
          qty: $qty
          sku: $sku
        }
      }
    }
  ) {
    cart {
      items {
        id
        qty
        product {
          sku
          stock_status
        }
        ... on SimpleCartItem {
          customizable_options {
            id
            is_required
            label
            type
            values {
              id
              label
              price {
                value
              }
              sort_order
            }
          }
        }
      }
    }
  }
}

with variables

{
  "cart_id": "4nsy2q2ldOGv2hcJqjnRUhH1Ub7r9TOt",
  "qty": 1,
  "sku": "simple-product-with-options"
}

I get this problem:

{
  "errors": [
    {
      "debugMessage": "Cannot return null for non-nullable field SelectedCustomizableOptionValue.sort_order.",
      "message": "Internal server error",
      "category": "internal",
      "locations": [
        {
          "line": 23,
          "column": 15
        }
      ],
      "path": [
        "addSimpleProductsToCart",
        "cart",
        "items",
        0,
        "customizable_options",
        0,
        "values",
        0,
        "sort_order"
      ]
    },
    {
      "debugMessage": "Cannot return null for non-nullable field SelectedCustomizableOptionValue.sort_order.",
      "message": "Internal server error",
      "category": "internal",
      "locations": [
        {
          "line": 23,
          "column": 15
        }
      ],
      "path": [
        "addSimpleProductsToCart",
        "cart",
        "items",
        0,
        "customizable_options",
        1,
        "values",
        0,
        "sort_order"
      ]
    },
    {
      "debugMessage": "Cannot return null for non-nullable field SelectedCustomizableOptionValue.sort_order.",
      "message": "Internal server error",
      "category": "internal",
      "locations": [
        {
          "line": 23,
          "column": 15
        }
      ],
      "path": [
        "addSimpleProductsToCart",
        "cart",
        "items",
        0,
        "customizable_options",
        2,
        "values",
        0,
        "sort_order"
      ]
    },
    {
      "debugMessage": "Cannot return null for non-nullable field SelectedCustomizableOptionValue.sort_order.",
      "message": "Internal server error",
      "category": "internal",
      "locations": [
        {
          "line": 23,
          "column": 15
        }
      ],
      "path": [
        "addSimpleProductsToCart",
        "cart",
        "items",
        0,
        "customizable_options",
        3,
        "values",
        0,
        "sort_order"
      ]
    }
  ],
  "data": {
    "addSimpleProductsToCart": {
      "cart": {
        "items": [
          {
            "id": "301",
            "qty": 2,
            "product": {
              "sku": "simple-product-with-options",
              "stock_status": "IN_STOCK"
            },
            "customizable_options": [
              {
                "id": 1,
                "is_required": 1,
                "label": "opt1",
                "type": "checkbox",
                "values": [
                  null
                ]
              },
              {
                "id": 2,
                "is_required": 1,
                "label": "opt2",
                "type": "radio",
                "values": [
                  null
                ]
              },
              {
                "id": 3,
                "is_required": 1,
                "label": "opt3",
                "type": "drop_down",
                "values": [
                  null
                ]
              },
              {
                "id": 4,
                "is_required": 1,
                "label": "opt4",
                "type": "multiple",
                "values": [
                  null
                ]
              }
            ]
          }
        ]
      }
    }
  }
}

[TomashKhamlai]

@XxXgeoXxX, please apply updates from mainline.

[naydav]

@TomashKhamlai I merged mainline, please, continue testing the issue

[naydav]

@XxXgeoXxX

Also 'sort_order' doesn't exist on values level.

Great point! It was a mistake in the initial scheme.

[ghost]

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.