This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Add API functional tests for ApplyCouponToCart functionality #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naydav
suggested changes
Apr 2, 2019
| /** | ||
| * @var CouponResourceInterface | ||
| */ | ||
| protected $couponResource; |
There was a problem hiding this comment.
Please, check and remove all of unused dependencies like this
| * @param string $sku | ||
| * @throws \Exception | ||
| */ | ||
| private function excludeProductPerCoupon(string $couponCode, string $sku) |
There was a problem hiding this comment.
Could we move this set-up to fixture file (with rollback)?
Example:
/**
* @magentoApiDataFixture Magento/Customer/_files/customer.php
* @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_shipping_address.php
*/
| 'test_order_with_simple_product_without_address', | ||
| 'reserved_order_id' | ||
| ); | ||
| $maskedQuoteId = $this->quoteIdToMaskedId->execute((int)$this->quote->getId()); |
There was a problem hiding this comment.
Looks like we can avoid manipulating with QuoteResource (etc..) if we will reuse current fixtures
/**
* @magentoApiDataFixture Magento/Customer/_files/customer.php
* @magentoApiDataFixture Magento/Catalog/_files/product_simple.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/customer/create_empty_cart.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/add_simple_product.php
* @magentoApiDataFixture Magento/GraphQl/Quote/_files/set_new_shipping_address.php
*/
|
@dmytro-ch |
…to-cart # Conflicts: # dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/CouponTest.php
|
Hello @naydav, Thank you! |
|
Hi @dmytro-ch, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Fixed Issues (if relevant)
Manual testing scenarios (*)
N/A
Contribution checklist (*)