This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Product media_gallery_entries / types only present if image, thumbnai… #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l, small_image is requested
…l, small_image is requested
…l-ce into 612-skip
…age, thumbnail, small_image is requested - skipped test magento#738
lenaorobei
changed the base branch from
2.3-develop
to
2.3-develop-plus-pr13-and-pr48
lenaorobei
changed the base branch from
2.3-develop-plus-pr13-and-pr48
to
2.3-develop
naydav
approved these changes
Jun 12, 2019
|
Hi @XxXgeoXxX, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l, small_image is requested
Description (*)
Original Issue #612
lib/internal/Magento/Framework/Model/AbstractModel.php doesn't add gallery attributes to the collection by default.
According to documentation gallery attributes must always include(MediaGalleryEntry: Array of image types. It can have the following values: image, small_image, thumbnail).
https://devdocs.magento.com/guides/v2.3/graphql/reference/products.html
Contribution checklist (*)