Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

Correct cart_item_id source for address items #853

Merged
merged 4 commits into from
Oct 22, 2019
Merged

Correct cart_item_id source for address items #853

merged 4 commits into from
Oct 22, 2019

Commits on Aug 24, 2019

  1. Correct cart_item_id source for address items 

    [`\Magento\Quote\Model\Quote\Address::getAllItems`](https://github.com/magento/magento2/blob/cf4dc427fed594f74b7168735ee1eb93febfc143/app/code/Magento/Quote/Model/Quote/Address.php#L592-L636) returns
`\Magento\Quote\Model\Quote\Address\Item[]` when the quote has multiple
shipping addresses and `Magento\Quote\Model\Quote\Item[]` with a single
shipping address. These objects have different methods for accessing the quote
item id and both variants need to be accommodated in the extractor.

Fixes magento#822
    @pmclain
    pmclain committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    f0bb8d5 View commit details
    Browse the repository at this point in the history

  2. Fix static test and remove unused import

    @pmclain
    pmclain committed Aug 24, 2019
    Configuration menu
    Copy the full SHA
    b2a21ed View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2019

  1. Merge remote-tracking branch 'upstream/2.3-develop' into issue/822

    @pmclain
    pmclain committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    16e8358 View commit details
    Browse the repository at this point in the history

  2. Fix test 

    `base_amount` is always returned as null
https://github.com/magento/graphql-ce/blob/4013a390348bf15ae48ddcaeecadae402351cf33/app/code/Magento/QuoteGraphQl/Model/Resolver/ShippingAddress/AvailableShippingMethods.php#L100
    @pmclain
    pmclain committed Sep 21, 2019
    Configuration menu
    Copy the full SHA
    9d54005 View commit details
    Browse the repository at this point in the history