Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

[Wishlist] Remove name from WishlistOutput #920 #957

Merged
merged 11 commits into from
Nov 1, 2019

Conversation

XxXgeoXxX
Copy link
Member

Description (*)

Original issue: #920

Questions or comments

  1. Should we create separate resolver for Customer instead use Wishlist resolver?
  2. Should we deprecated query 'Wishlists'?

Note: I'm working to coverage this mutation by functional tests.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the logic for getting customer wish list to the separate class with execute method and use it in both places - where array of wishlists and single wish list is returned.

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6165 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei
Copy link
Contributor

fixed #1038

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6165 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team merged commit 6b443b4 into magento:2.3-develop Nov 1, 2019
@ghost
Copy link

ghost commented Nov 1, 2019

Hi @XxXgeoXxX, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants