Skip to content
This repository has been archived by the owner on Dec 19, 2019. It is now read-only.

magento/graphql-ce#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart #996

Merged
merged 3 commits into from
Oct 23, 2019
Merged

magento/graphql-ce#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart #996

merged 3 commits into from
Oct 23, 2019

Conversation

atwixfirster
Copy link
Contributor

@atwixfirster atwixfirster commented Oct 9, 2019 •
edited
Loading

Description (*)

Fixed Issues (if relevant)

  1. [Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart #977: [Test coverage] Cover exceptions in AssignShippingAddressToCart, AssignBillingAddressToCart

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

lenaorobei
lenaorobei suggested changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@lenaorobei lenaorobei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set address not from the address book (send address in mutation body, not customer_address_id ) so we will test invalid input.
customer_address_set_invalid_country_id.php fisture should be removed.

@atwixfirster
Copy link
Contributor Author

Please set address not from the address book (send address in mutation body, not customer_address_id ) so we will test invalid input.
customer_address_set_invalid_country_id.php fisture should be removed.

Good suggestion!

implemented

Thank you, @lenaorobei

@TomashKhamlai TomashKhamlai added the QA in progress We are checking label Oct 11, 2019
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-6061 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei
Copy link
Contributor

@atwixfirster please pull latest code from 2.3-develop and resolve conflicts.

@atwixfirster
#977: [Test coverage] Cover exceptions in AssignShippingAddressToCart…
5bf67e5 
…, AssignBillingAddressToCart

Merge remote-tracking branch 'origin/2.3-develop' into 977-address-to-customer

# Conflicts:
#	dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetBillingAddressOnCartTest.php
#	dev/tests/api-functional/testsuite/Magento/GraphQl/Quote/Customer/SetShippingAddressOnCartTest.php
@atwixfirster
Copy link
Contributor Author

@atwixfirster please pull latest code from 2.3-develop and resolve conflicts.

done, ma'am :)

@magento-engcom-team magento-engcom-team mentioned this pull request Oct 23, 2019
Closed
magento-engcom-team pushed a commit that referenced this pull request Oct 23, 2019
@lenaorobei
ENGCOM-6061: #977: [Test coverage] Cover exceptions in AssignShipping…
c4abc57 
…AddressToCart, AssignBillingAddressToCart #996
@magento-engcom-team magento-engcom-team merged commit f49fe71 into 2.3-develop Oct 23, 2019
@ghost
Copy link

ghost commented Oct 23, 2019

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@okorshenko okorshenko deleted the 977-address-to-customer branch December 18, 2019 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@paliarush paliarush Awaiting requested review from paliarush

Assignees

@lenaorobei lenaorobei

Labels
Auto-Tests: Covered Award: test coverage Component: QuoteGraphQl Partner: Atwix partners-contribution QA in progress We are checking Release Line: 2.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atwixfirster @magento-engcom-team @lenaorobei @TomashKhamlai