Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSI-2876: Change all fixture paths to module namespace path #2931

Conversation

vadimjustus
Copy link
Contributor

Description (*)

Since Magento version 2.3 it is possible to use module name to have a runtime resolved path to the module within the @magentoDataFixture annotations. All absolute paths were replaced e.g. @magentoDataFixture ../../../../app/code/Magento/InventoryApi/Test/_files/stocks.php => @magentoDataFixture Magento_InventoryApi::Test/_files/stocks.php

Fixed Issues (if relevant)

  1. Hard coded paths to integration test fixture files makes integration testing difficult #2876: Hard coded paths to integration test fixture files makes integration testing difficult

Manual testing scenarios (*)

  1. Install MSI development environment as per documentation at https://github.com/magento/inventory/wiki/Metapackage-Installation-Guide
  2. Execute integration tests

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

sidolov
sidolov previously approved these changes Apr 5, 2020
sidolov
sidolov previously approved these changes Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard coded paths to integration test fixture files makes integration testing difficult
3 participants