Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP error with short class names #426

Merged

Conversation

fredden
Copy link
Member

@fredden fredden commented Oct 15, 2022

Fixes #425

@sidolov
Copy link
Collaborator

sidolov commented Feb 14, 2023

@magento import pr to magento-commerce/magento-coding-standard repository

@m2-github-services
Copy link
Contributor

@sidolov the Pull Request is successfully imported.

@sidolov
Copy link
Collaborator

sidolov commented Feb 14, 2023

@fredden there is a merge conflict with the base branch, could you please resolve it?

@fredden
Copy link
Member Author

fredden commented Mar 24, 2023

@sidolov please can we get this pull request (and others in this repository?) merged in, and a new release created?

@sidolov
Copy link
Collaborator

sidolov commented Mar 28, 2023

@magento import pr to magento-commerce/magento-coding-standard repository

@m2-github-services
Copy link
Contributor

@sidolov the Pull Request is successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 94041d7 into magento:develop Mar 28, 2023
@fredden fredden deleted the less-class-naming-strpos branch March 28, 2023 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants