Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQE-899: Excessive double quotes are being generated in WaitForElementChange method arguments #103

Merged
merged 2 commits into from
Apr 19, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Apr 19, 2018

Description

  • Fixed quote issue in waitForElementChanged. Also included fix for performOn, as it's the only other codeception function that takes a closure as an argument.

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<899>: Excessive double quotes are being generated in WaitForElementChange method arguments
  2. Excessive double quotes are being generated in WaitForElementChange method arguments #68

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…tChange method arguments

- Fixed quote issue in waitForElementChanged. Also included fix for performOn, as it's the only other codeception function that takes a closure as an argument.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 50.36% when pulling f81ab93 on MQE-899 into ebbe2d1 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 50.36% when pulling f81ab93 on MQE-899 into ebbe2d1 on develop.

@coveralls
Copy link

coveralls commented Apr 19, 2018

Coverage Status

Coverage decreased (-0.4%) to 50.36% when pulling 518f896 on MQE-899 into 298bbca on develop.

@KevinBKozan KevinBKozan merged commit df4db87 into develop Apr 19, 2018
@KevinBKozan KevinBKozan deleted the MQE-899 branch April 19, 2018 20:23
magento-devops-reposync-svc pushed a commit that referenced this pull request Aug 23, 2021
…o2-functional-testing-framework-868

[Imported] PHP 8 support - fix code related to changes in CURL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants