Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variables #256

Merged
merged 1 commit into from
Oct 25, 2018
Merged

Conversation

gy741
Copy link
Contributor

@gy741 gy741 commented Oct 25, 2018

Description

Hello,

In my opinion, No $key variables are required.

Because it is not used.

What do you think of it?

Thanks.

Fixed Issues (if relevant)

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Oct 25, 2018

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.482% when pulling 0972b86 on gy741:remove_dead_code into f0779ac on magento:develop.

@KevinBKozan
Copy link
Contributor

KevinBKozan commented Oct 25, 2018

@gy741 Thank you for your contribution! We will update this PR with progress information as we process it.

@KevinBKozan KevinBKozan merged commit 4c8b297 into magento:develop Oct 25, 2018
magento-devops-reposync-svc pushed a commit that referenced this pull request Dec 12, 2022
MFTF 4.0.0 Release checklist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants