Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow = to be part of the secret value #297

Merged
merged 2 commits into from
Jan 22, 2019
Merged

Conversation

fooman
Copy link
Contributor

@fooman fooman commented Jan 21, 2019

Description

After this pull request is merged your secret value in .credentials can include the = character as part of its value

Fixed Issues (if relevant)

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Jan 21, 2019

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 21, 2019

Coverage Status

Coverage decreased (-0.008%) to 57.054% when pulling 698f0a0 on fooman:patch-1 into c80e1d3 on magento:develop.

@KevinBKozan
Copy link
Contributor

@fooman Thank you for your contribution! We review the contents of the PR and update as it is reviewed and processed.

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@jilu1 jilu1 merged commit e1cd4e1 into magento:develop Jan 22, 2019
magento-devops-reposync-svc pushed a commit that referenced this pull request May 31, 2023
…eption

Fix internal exception in codeception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants