Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMALL_CHANGE: Minor change suggested #403

Merged
merged 3 commits into from
Jul 31, 2019
Merged

Conversation

diazwatson
Copy link
Contributor

Description

Minor change suggested to improve explanation of how to set up an embedded MFTF

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-cicd2
Copy link

magento-cicd2 commented Jul 30, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added partners-contribution Pull Request is created by Magento Partner Partner: Space 48 labels Jul 30, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 54.73% when pulling 2ca3d95 on diazwatson-patch-1 into ec1dd8f on master.

@coveralls
Copy link

coveralls commented Jul 30, 2019

Coverage Status

Coverage increased (+1.6%) to 56.211% when pulling 658dc22 on diazwatson-patch-1 into ec1dd8f on master.

@KevinBKozan KevinBKozan requested a review from dobooth July 31, 2019 13:44
@KevinBKozan
Copy link
Contributor

Hi @diazwatson, thank you for your contribution! I've requested @dobooth to review this as it's a documentation only change.

We'll keep you updated as this PR progresses.

@dobooth dobooth added the DOC label Jul 31, 2019
@KevinBKozan KevinBKozan merged commit 4a430db into master Jul 31, 2019
@diazwatson diazwatson deleted the diazwatson-patch-1 branch July 31, 2019 23:40
magento-devops-reposync-svc pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants