-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Command added to modifiy the web server rewrites configurtion #678
Merged
tomreece
merged 7 commits into
magento:develop
from
ajithkumar-maragathavel:web-server-rewrites
Jul 24, 2020
Merged
Command added to modifiy the web server rewrites configurtion #678
tomreece
merged 7 commits into
magento:develop
from
ajithkumar-maragathavel:web-server-rewrites
Jul 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Ziffity
partners-contribution
Pull Request is created by Magento Partner
labels
Apr 19, 2020
lbajsarowicz
previously approved these changes
Apr 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Interesting change. It's assumed that rewrites are turned on, but it's worth to add this explicitly.
okolesnyk
previously approved these changes
Apr 23, 2020
dobooth
approved these changes
Apr 24, 2020
okolesnyk
approved these changes
Jul 24, 2020
tomreece
approved these changes
Jul 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by @dobooth also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Affected Pages
https://devdocs.magento.com/mftf/docs/getting-started.html#nginx-settings
Added a CLI command to modify the web server rewrites configuration and also added cache clean command after changing the values.
Note:
I have also verified the CLI command to modify the web server rewrites works as expected in my local development evironment.
Contribution checklist