Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command added to modifiy the web server rewrites configurtion #678

Merged
merged 7 commits into from
Jul 24, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description

Affected Pages
https://devdocs.magento.com/mftf/docs/getting-started.html#nginx-settings

Added a CLI command to modify the web server rewrites configuration and also added cache clean command after changing the values.

Note:
I have also verified the CLI command to modify the web server rewrites works as expected in my local development evironment.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Apr 19, 2020
@coveralls
Copy link

coveralls commented Apr 19, 2020

Coverage Status

Coverage remained the same at 56.074% when pulling ee2b7ac on ajithkumar-maragathavel:web-server-rewrites into d890e05 on magento:develop.

lbajsarowicz
lbajsarowicz previously approved these changes Apr 19, 2020
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Interesting change. It's assumed that rewrites are turned on, but it's worth to add this explicitly.

@okolesnyk okolesnyk self-requested a review April 23, 2020 15:00
okolesnyk
okolesnyk previously approved these changes Apr 23, 2020
@okolesnyk okolesnyk requested a review from dobooth April 23, 2020 15:00
@dobooth dobooth dismissed stale reviews from okolesnyk and lbajsarowicz via 67afbb0 April 24, 2020 14:30
@dobooth dobooth added the DOC label Jul 24, 2020
Copy link
Contributor

@tomreece tomreece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @dobooth also.

@tomreece tomreece merged commit 46c69f5 into magento:develop Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Partner: Ziffity partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants