Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added examples and modified url links #812

Merged

Conversation

ajithkumar-maragathavel
Copy link
Contributor

Description

This PR adds example code snippets for the assert nodes and also updated the invalid external URL links with the correct URLs.

Affected Pages

  1. https://devdocs.magento.com/mftf/docs/test/assertions.html
  2. https://devdocs.magento.com/mftf/docs/test.html

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Jan 10, 2021
@jilu1
Copy link
Contributor

jilu1 commented Mar 31, 2021

@magento-engcom-team
Copy link

@jilu1 the pull request successfully imported.

@jilu1
Copy link
Contributor

jilu1 commented Apr 1, 2021

@ajithkumar-maragathavel Thank you for your PR!
We are processing this PR and contents will be in release 3.5.0.

@magento-cicd2 magento-cicd2 merged commit d26ecae into magento:develop Apr 5, 2021
@jilu1 jilu1 removed the in progress label Apr 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants