Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with missing method argument type #101

Merged
merged 4 commits into from
Jan 8, 2020

Conversation

lenaorobei
Copy link
Contributor

Fixed issue:
"Warning: Declaration of CommunityEngineering\JapaneseName\Model\DataObject\Copy::setAttributeValueFromExtensibleDataObject($target, $code, $value) should be compatible with Magento\Framework\DataObject\Copy::setAttributeValueFromExtensibleDataObject(Magento\Framework\Api\ExtensibleDataInterface $target, $code, $value) in /var/www/html/vendor/community-engineering/module-japanese-name/Model/DataObject/Copy.php on line 19"

@smoskaluk
Copy link

smoskaluk commented Dec 26, 2019

@lenaorobei I got next error after creating Credit Memo for order with 1 item of simple product.

cr_memo_JP

I've used local inviroment - magento branch 2.4-develop from https://github.com/magento/magento2.git repository + this PR branch - installed according manual here, with no 3 part modules enabled.
I'm working on PHP 7.2.26-1+ubuntu16.04.1+deb.sury.org+1 (cli) + chromium 79

@HirokazuNishi
Copy link
Collaborator

@smoskaluk Please provide your environment info as same as magento2 repository requests.

@lenaorobei
Copy link
Contributor Author

@smoskaluk could you please check again?
If will fail please provide additional info, like did you change any configuration? What is the currency of the product?

@smoskaluk
Copy link

smoskaluk commented Jan 6, 2020

@lenaorobei
I checked again, and issue is still there.
I didn't any changes in configuration, all setting are by default, currency is JPY.
I do next:

  1. Create simple product
  2. Place order with it
  3. Create Invoice for this order
  4. Create Credit Memo
  5. Open 'Credit Memo' tab on my order page in admin

image

@lenaorobei
Copy link
Contributor Author

Thanks @smoskaluk, I was able to reproduce this bug and fix the issue.
Could you please check again? Please use 2.3-develop. This extension is not compatible with 2.4 yet, but we will work on it soon.

@lenaorobei lenaorobei merged commit c6ab92c into 2.3-develop Jan 8, 2020
@smoskaluk
Copy link

I've checked, it works.

@lenaorobei lenaorobei deleted the fix-expected-type branch January 9, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants